Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update_binary not called when only password related parameter changes #36

Closed
shk3bq4d opened this issue Feb 1, 2018 · 0 comments
Closed

update_binary not called when only password related parameter changes #36

shk3bq4d opened this issue Feb 1, 2018 · 0 comments

Comments

@shk3bq4d
Copy link

shk3bq4d commented Feb 1, 2018

I think title says it all.

I am sending a MR pretty soon, hoping it will be welcomed.
shk3bq4d pushed a commit to shk3bq4d/puppet-grub2 that referenced this issue Feb 1, 2018
fixes issue goldyfruit#36
6619979 
-
@baurmatt baurmatt mentioned this issue Mar 26, 2018
Closed
baurmatt added a commit to syseleven/puppet-grub2 that referenced this issue Mar 26, 2018
@baurmatt
Fix module for non-password setups.
dc2d827 
This fixes a regression introduced with goldyfruit#36. It broken the module for
all setups which do not set grub2::password by always letting
grub::update subscribe to the password file.

Fixes goldyfruit#40
@baurmatt baurmatt mentioned this issue Mar 26, 2018
Merged
baurmatt added a commit to syseleven/puppet-grub2 that referenced this issue Mar 26, 2018
@baurmatt
Fix module for non-password setups.
765789f 
This fixes a regression introduced with goldyfruit#36. It broken the module for
all setups which do not set grub2::password by always letting
grub::update subscribe to the password file.

Fixes goldyfruit#40
baurmatt added a commit to syseleven/puppet-grub2 that referenced this issue Mar 26, 2018
@baurmatt
Fix module for non-password setups.
52f7ab9 
This fixes a regression introduced with goldyfruit#36. It broken the module for
all setups which do not set grub2::password by always letting
grub::update subscribe to the password file.

Fixes goldyfruit#40
baurmatt added a commit to syseleven/puppet-grub2 that referenced this issue Mar 26, 2018
@baurmatt
open-prs-39-41 - Fix module for non-password setups.
e0028cb 
This fixes a regression introduced with goldyfruit#36. It broken the module for
all setups which do not set grub2::password by always letting
grub::update subscribe to the password file.

Fixes goldyfruit#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goldyfruit @shk3bq4d