Change poe tasks naming #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approxit
requested changes
Jan 17, 2023
shadeofblue
reviewed
Jan 18, 2023
lucekdudek
changed the title
approxit
requested changes
Jan 31, 2023
It always has .lock so we can keep it as for now |
approxit
approved these changes
Feb 7, 2023
approxit
approved these changes
Feb 7, 2023
lucekdudek
force-pushed
the
ld/bump-mitmproxy-and-black
branch
from
b944572
to
3c704f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial gole of this PR was to bump goth's dependencies so it is possible to use
click>=8(dependency ofmitmproxyandblack). Unfortunately, goth yields unexpected errors when usingmitmproxy>=7. I ended up with bumping versions slightly. As a resultclick>=8is still not supported.What has been done:
.flake8to pyproject.toml (this required flak8 bump to^5)^6tool.poe.tasksso they match other golemfactory python project (including github workflows configurations)mypyto newer version -poe checks_typingyields the same warning on both versionsmitmproxymore: Bump mitmproxy version to ^8 #605yapapi compatibility test
golemfactory/yapapi#1093
Edit: After yapapi compatibility test we decided to not upgrade
mitmproxyat all and only merge changes to poe tasks and dev packages upgrade