Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events and API unification - Market, Activity & Payment API #53

Merged
merged 22 commits into from
Dec 10, 2020
Merged

Events and API unification - Market, Activity & Payment API #53

merged 22 commits into from
Dec 10, 2020

Conversation

stranger80
Copy link
Contributor

@stranger80 stranger80 commented Oct 24, 2020 •
edited
Loading

@stranger80 stranger80 mentioned this pull request Oct 24, 2020
Closed
@stranger80 stranger80 changed the title API unification & events - Market, Activity & Payment API Events and API unification - Market, Activity & Payment API Oct 24, 2020
tworec
tworec suggested changes Oct 26, 2020
View reviewed changes
specs/activity-api.yaml Show resolved Hide resolved
specs/activity-api.yaml Show resolved Hide resolved
specs/activity-api.yaml Outdated Show resolved Hide resolved
specs/activity-api.yaml Show resolved Hide resolved
specs/common.yaml Outdated Show resolved Hide resolved
specs/common.yaml Outdated Show resolved Hide resolved
specs/common.yaml Outdated Show resolved Hide resolved
specs/common.yaml Show resolved Hide resolved
specs/exe-script.yaml Outdated Show resolved Hide resolved
specs/exe-script.yaml Outdated Show resolved Hide resolved
@tworec tworec mentioned this pull request Oct 26, 2020
Merged
tworec
tworec suggested changes Oct 26, 2020
View reviewed changes
specs/market-api.yaml Outdated Show resolved Hide resolved
specs/market-api.yaml Outdated Show resolved Hide resolved
specs/market-api.yaml Outdated Show resolved Hide resolved
specs/market-api.yaml Outdated Show resolved Hide resolved
specs/market-api.yaml Outdated Show resolved Hide resolved
specs/market-api.yaml Outdated Show resolved Hide resolved
specs/market-api.yaml Outdated Show resolved Hide resolved
specs/market-api.yaml Outdated Show resolved Hide resolved
tworec
tworec reviewed Oct 27, 2020
View reviewed changes
specs/payment-api.yaml Outdated Show resolved Hide resolved
tworec
tworec suggested changes Oct 27, 2020
View reviewed changes
specs/market-api.yaml Outdated Show resolved Hide resolved
specs/market-api.yaml Outdated Show resolved Hide resolved
specs/market-api.yaml Outdated Show resolved Hide resolved
specs/market-api.yaml Outdated Show resolved Hide resolved
@stranger80
Copy link
Contributor Author

OK, seems all comments have been addressed now.

tworec
tworec previously approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@tworec tworec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tworec
tworec reviewed Nov 2, 2020
View reviewed changes
specs/market-api.yaml Outdated Show resolved Hide resolved
tworec
tworec reviewed Nov 2, 2020
View reviewed changes
specs/market-api.yaml Outdated Show resolved Hide resolved
tworec
tworec reviewed Nov 2, 2020
View reviewed changes
specs/market-api.yaml Outdated Show resolved Hide resolved
tworec
tworec reviewed Nov 3, 2020
View reviewed changes
specs/market-api.yaml Outdated Show resolved Hide resolved
tworec
tworec reviewed Nov 3, 2020
View reviewed changes
specs/market-api.yaml Outdated Show resolved Hide resolved
tworec
tworec reviewed Nov 3, 2020
View reviewed changes
specs/market-api.yaml Outdated Show resolved Hide resolved
tworec
tworec reviewed Nov 3, 2020
View reviewed changes
specs/common.yaml Outdated Show resolved Hide resolved
tworec
tworec reviewed Nov 3, 2020
View reviewed changes
specs/market-api.yaml Outdated Show resolved Hide resolved
tworec
tworec reviewed Nov 18, 2020
View reviewed changes
specs/market-api.yaml Outdated Show resolved Hide resolved
specs/market-api.yaml Outdated Show resolved Hide resolved
@tworec tworec mentioned this pull request Nov 18, 2020
Closed
1 task
@tworec tworec linked an issue Nov 18, 2020 that may be closed by this pull request
Verify proposed changes for Event API #65
Closed
1 task
tworec
tworec reviewed Nov 19, 2020
View reviewed changes
specs/market-api.yaml Outdated Show resolved Hide resolved
tworec
tworec reviewed Nov 20, 2020
View reviewed changes
specs/market-api.yaml Outdated Show resolved Hide resolved
@tworec tworec mentioned this pull request Nov 25, 2020
Closed
5 tasks
@maaktweluit maaktweluit mentioned this pull request Dec 9, 2020
Merged
@tworec tworec changed the base branch from master to event-api/master December 10, 2020 15:56
@stranger80
Merge pull request #70 from golemfactory/2rec/market-event-api
8fcbc2b 
[mkt spec] Make REST responses compliant with standard HTTP Codes semantics
@stranger80 stranger80 merged commit a408d7c into event-api/master Dec 10, 2020
@tworec tworec mentioned this pull request Dec 11, 2020
Closed
@tworec tworec deleted the stranger80/all-apis-events branch December 14, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranciszkiewicz mfranciszkiewicz mfranciszkiewicz left review comments

@maaktweluit maaktweluit maaktweluit left review comments

@tworec tworec tworec left review comments

@nieznanysprawiciel nieznanysprawiciel Awaiting requested review from nieznanysprawiciel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify proposed changes for Event API
4 participants
@stranger80 @tworec @mfranciszkiewicz @maaktweluit