Gnt driver #110
Merged
Gnt driver #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bidzyyys
commented
Feb 18, 2020
•
bidzyyys
commented
- request_funds_from_faucet
- get_account_balance
- schedule_payment
- get_payment_status
- verify_payment
- get_transaction_balance
This comment has been minimized.
This comment has been minimized.
bidzyyys
force-pushed
the
feature/gnt_driver
branch
2 times, most recently
from
d6b6c22
to
a20c15c
Compare
bidzyyys
force-pushed
the
feature/gnt_driver
branch
from
a20c15c
to
6039bae
Compare
Wiezzel
reviewed
Feb 19, 2020
core/payment-driver/src/ethereum.rs
Outdated
| Err(PaymentDriverError::LibraryError { | ||
| msg: format!("{}", e), | ||
| }) | ||
| }, |
There was a problem hiding this comment.
I recommend implementing appropriate From traits for error conversion. This whole method body could look like this:
Ok(Contract::from_json(self.web3.eth(), address, json_abi)?)
bidzyyys
force-pushed
the
feature/gnt_driver
branch
5 times, most recently
from
40359ef
to
dc417c2
Compare
tworec
force-pushed
the
feature/gnt_driver
branch
from
d15ac77
to
aad7cb4
Compare
Wiezzel
force-pushed
the
feature/gnt_driver
branch
from
461c388
to
ae5cded
Compare
Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
* Moved faucet addresses to GntDriver constructor * Implemented init() for GntDriver * Created separate factory methods and feature flags for GNT and Dummy Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
…to feature/gnt_driver
Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
prekucki
previously approved these changes
Mar 6, 2020
prekucki
approved these changes
Mar 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.