Fix: Change metric from driver to platform #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieznanysprawiciel
requested review from
jiivan,
tworec,
maaktweluit and
Wiezzel
Wiezzel
suggested changes
Mar 9, 2021
core/payment/src/processor.rs
Outdated
| @@ -388,7 +388,7 @@ impl PaymentProcessor { | |||
| activity_payment.allocation_id = None; | |||
| } | |||
|
|
|||
| counter!("payment.amount.sent", ya_metrics::utils::cryptocurrency_to_u64(&msg.amount), "driver" => msg.driver); | |||
| counter!("payment.amount.sent", ya_metrics::utils::cryptocurrency_to_u64(&msg.amount), "platform" => msg.driver); | |||
There was a problem hiding this comment.
The value should be payment_platform not msg.driver then.
There was a problem hiding this comment.
Thanks for noticing
There was a problem hiding this comment.
Now you're using a moved value. Compile before committing. :P
There was a problem hiding this comment.
Eh. I hoped it will be easy fix :P
nieznanysprawiciel
force-pushed
the
payments/fix-change-metric-to-platform
branch
2 times, most recently
from
c8237a2
to
d5d03cc
Compare
nieznanysprawiciel
force-pushed
the
payments/fix-change-metric-to-platform
branch
from
d5d03cc
to
9e325b6
Compare
Wiezzel
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.