Added transfer for erc20 driver #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiezzel
reviewed
Mar 30, 2021
maaktweluit
force-pushed
the
mwu/erc20-transfer
branch
from
fa55c54
to
568b066
Compare
maaktweluit
force-pushed
the
mwu/erc20-transfer
branch
from
568b066
to
132d0d1
Compare
Merged
Wiezzel
approved these changes
Mar 31, 2021
| ); | ||
| log::info!("{}", message); | ||
| log::debug!("tx_id={}", tx_id); | ||
| Ok(message) |
There was a problem hiding this comment.
This message is fine for logging but for user output I'd go with etherscan link.
There was a problem hiding this comment.
good catch! made an issue for this: https://golemproject.atlassian.net/browse/PAY-292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yagna payment transferon--driver erc20get_next_noncetowallet