Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExeUnit cache: cleaner cache/tmp, less intermediary files #1340

Merged
merged 1 commit into from
May 24, 2021
Merged

ExeUnit cache: cleaner cache/tmp, less intermediary files #1340

merged 1 commit into from
May 24, 2021

Conversation

mfranciszkiewicz
Copy link
Contributor

  • hash is now included in target image name
  • skip an intermediary cache file
  • fix: remove temporary files on transfer failure

Resolves #1319

@mfranciszkiewicz
ExeUnit cache: cleaner cache/tmp, less intermediary files
4a6bc60 
- hash is now included in target image name
- remove intermediary cache image name
- fix: remove temporary files on transfer failure
@mfranciszkiewicz mfranciszkiewicz requested review from a team and prekucki May 21, 2021 14:19
@mfranciszkiewicz mfranciszkiewicz linked an issue May 21, 2021 that may be closed by this pull request
multiple copies of the gvmi image in their exe-unit/cache/tmp directory #1319
Closed
@mfranciszkiewicz mfranciszkiewicz removed the request for review from prekucki May 21, 2021 14:22
@tworec tworec assigned jiivan and maaktweluit and unassigned jiivan May 24, 2021
maaktweluit
maaktweluit approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Not the best at this part of the code yet, but as far as i can see its a neat improvement!

@tworec tworec merged commit 14de663 into release/v0.6 May 24, 2021
@tworec tworec deleted the mf/exe-unit-cache branch May 24, 2021 11:51
@tworec tworec mentioned this pull request May 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maaktweluit maaktweluit maaktweluit approved these changes

Assignees

@maaktweluit maaktweluit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multiple copies of the gvmi image in their exe-unit/cache/tmp directory
4 participants
@mfranciszkiewicz @maaktweluit @jiivan @tworec