-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gftp file upload #137
Gftp file upload #137
Conversation
nieznanysprawiciel
commented
Mar 3, 2020
- uploading files through gsb
- no integration with ExeUnit transfers
impl FileDesc { | ||
fn new(file: fs::File, hash: String, meta: model::GftpMetadata) -> Arc<Self> { | ||
let file = Mutex::new(file); | ||
|
||
Arc::new(FileDesc { hash, file, meta }) | ||
} | ||
|
||
pub fn open(path: &Path, config: &Config) -> Result<Arc<FileDesc>> { | ||
pub fn open(path: &Path) -> Result<Arc<FileDesc>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more specific error type would help a lot with integrating gftp
with other parts of the application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean, that I should rather return model::Error than anyhow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be preferable
Included in #136 |