Market decentralized - provider counter draft proposal #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tworec
suggested changes
Jul 14, 2020
core/market/decentralized/migrations/2020-05-15-093513_init-db/up.sql
Outdated
Show resolved
Hide resolved
Co-authored-by: Piotr Chromiec <tworec@golem.network>
tworec
suggested changes
Jul 14, 2020
| // Map model events to client RequestorEvent. | ||
| let db = self.db(); | ||
| Ok(futures::stream::iter(events) | ||
| .then(|event| event.into_client_requestor_event(&db)) |
There was a problem hiding this comment.
same here
Suggested change
| .then(|event| event.into_client_requestor_event(&db)) | |
| .then(|event| event.into_client_requestor_event(&self.common.db)) |
| .filter_map(|event| event.ok()) | ||
| .collect::<Vec<RequestorEvent>>()) | ||
| fn db(&self) -> DbExecutor { | ||
| self.common.db.clone() |
| @@ -29,6 +29,8 @@ pub enum RemoteProposalError { | |||
| Unsubscribed(SubscriptionId), | |||
| #[error("Offer/Demand [{0}] expired.")] | |||
| Expired(SubscriptionId), | |||
| #[error("Trying to counter not existing Proposal [{0}].")] | |||
| ProposalNotFound(ProposalId), | |||
There was a problem hiding this comment.
we are in the context of Proposal and this will always be used like RemoteProposalError::NotFound
Suggested change
| ProposalNotFound(ProposalId), | |
| NotFound(ProposalId), |
| .requestor_engine | ||
| .query_events(&demand_id, 1.2, Some(5)) | ||
| .await?; | ||
| let proposal0 = requestor::expect_proposal(events)?; |
There was a problem hiding this comment.
would be good to assert proposal0 props below eg. status Initial
tworec
previously approved these changes
Jul 15, 2020
tworec
previously approved these changes
Jul 15, 2020
tworec
force-pushed
the
market-decentralized/provider-counter-draft-proposal-rb
branch
from
71e8ac7
to
8aecb3e
Compare
tworec
force-pushed
the
market-decentralized/provider-counter-draft-proposal-rb
branch
2 times, most recently
from
71e8ac7
to
b077496
Compare
tworec
approved these changes
Jul 15, 2020
tworec
deleted the
market-decentralized/provider-counter-draft-proposal-rb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #363
resolves: #376