Adapt to new Market Api 1.6.1 #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tworec
force-pushed
the
market/new-market-api-1.6.1
branch
from
a7e7f8e
to
ca3052b
Compare
Wiezzel
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
Looks fine, but you gotta merge golemfactory/ya-client#52 ;)
nieznanysprawiciel
approved these changes
Nov 9, 2020
| Ok(ProposalResponse::RejectProposal) | ||
| Ok(ProposalResponse::RejectProposal { | ||
| reason: Some(format!( | ||
| "proposal expired at: {} which is less than 5 min or more than 30 min from now", |
There was a problem hiding this comment.
Suggested change
| "proposal expired at: {} which is less than 5 min or more than 30 min from now", | |
| "Proposal expires at: {} which is less than 5 min or more than 30 min from now", |
| Ok(ProposalResponse::RejectProposal) | ||
| Ok(ProposalResponse::RejectProposal { | ||
| reason: Some(format!( | ||
| "available agreements limit: {} reached", |
There was a problem hiding this comment.
Suggested change
| "available agreements limit: {} reached", | |
| "Node busy. Reached Agreements limit: {}", |
| Ok(AgreementResponse::RejectAgreement) | ||
| Ok(AgreementResponse::RejectAgreement { | ||
| reason: Some(format!( | ||
| "available agreements limit: {} reached", |
There was a problem hiding this comment.
Suggested change
| "available agreements limit: {} reached", | |
| "Node busy. Reached Agreements limit: {}", |
| @@ -16,7 +16,10 @@ pub enum ProposalResponse { | |||
| offer: DemandOfferBase, | |||
| }, | |||
| AcceptProposal, | |||
| RejectProposal, | |||
| #[display(fmt = "RejectProposal( reason: {:?})", reason)] | |||
There was a problem hiding this comment.
It will be awfull message with Some()
There was a problem hiding this comment.
Let's cover it in other PR, as this is blocking others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conform to changes in golemfactory/ya-client#52