Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging to file #895

Merged
merged 11 commits into from
Jan 11, 2021
Merged

logging to file #895

merged 11 commits into from
Jan 11, 2021

Conversation

etam
Copy link
Contributor

@etam etam commented Dec 21, 2020

closes #882

@etam etam self-assigned this Dec 21, 2020
@etam etam requested review from a team and prekucki and removed request for prekucki December 21, 2020 16:31
etam
etam commented Dec 21, 2020
View reviewed changes
utils/path/src/data_dir.rs Outdated Show resolved Hide resolved
tworec
tworec suggested changes Dec 21, 2020
View reviewed changes
core/serv/src/main.rs Outdated Show resolved Hide resolved
core/serv/src/main.rs Outdated Show resolved Hide resolved
core/serv/src/main.rs Outdated Show resolved Hide resolved
core/serv/src/main.rs Show resolved Hide resolved
core/serv/src/main.rs Outdated Show resolved Hide resolved
exe-unit/Cargo.toml Outdated Show resolved Hide resolved
@tworec tworec force-pushed the etam/logging_to_file branch 3 times, most recently from 4eb6162 to 6d8c71d Compare December 21, 2020 17:40
tworec
tworec previously approved these changes Dec 21, 2020
View reviewed changes
@tworec tworec removed the request for review from a team December 21, 2020 17:54
@tworec
Copy link
Contributor

tworec commented Dec 22, 2020 •
edited
Loading

It would be intuitive to use data_dir as a default place to store logs.

Currently, log_dir is separate setting which only shares default value with data_dir.

https://www.notion.so/golemnetwork/Event-API-testing-session-81e92bf06e5e49f8a65eea9f66d6a83b#e97d8f778b5340c7b6d822acebc2fff9

@etam
Copy link
Contributor Author

etam commented Dec 23, 2020

It would be intuitive to use data_dir as a default place to store logs.

Currently, log_dir is separate setting which only shares default value with data_dir.

https://www.notion.so/golemnetwork/Event-API-testing-session-81e92bf06e5e49f8a65eea9f66d6a83b#e97d8f778b5340c7b6d822acebc2fff9

Done

@etam etam requested a review from tworec December 23, 2020 11:04
tworec
tworec reviewed Dec 28, 2020
View reviewed changes
core/serv/src/main.rs Outdated Show resolved Hide resolved
@tworec tworec added this to the Mkt & Prov MVP milestone Dec 28, 2020
tworec
tworec previously approved these changes Dec 29, 2020
View reviewed changes
@etam etam merged commit 1064c71 into master Jan 11, 2021
@etam etam deleted the etam/logging_to_file branch January 11, 2021 15:45
@etam etam mentioned this pull request Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiivan jiivan jiivan left review comments

@tworec tworec tworec approved these changes

@nieznanysprawiciel nieznanysprawiciel nieznanysprawiciel left review comments

Assignees

@etam etam

Labels
None yet
Projects
None yet
Milestone
Mkt & Prov MVP
Development

Successfully merging this pull request may close these issues.

add file logging to yagna and ya-provider
4 participants
@etam @tworec @jiivan @nieznanysprawiciel