Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved all query string serialization in payment api to 'serde_qs' #908

Merged
merged 4 commits into from
Jan 13, 2021
Merged

Moved all query string serialization in payment api to 'serde_qs' #908

merged 4 commits into from
Jan 13, 2021

Conversation

maaktweluit
Copy link
Contributor

Please do not merge until all event-api/master's are properly merged

Cleanup after event api, no changes to logic.

  • Moved query param objects to payments model
  • Updated client api to use these for serialisation
  • Moved defaults to be set on the server side

@maaktweluit maaktweluit self-assigned this Jan 11, 2021
@maaktweluit maaktweluit requested a review from a team January 11, 2021 13:53
@maaktweluit maaktweluit changed the title Mwu/extract params Moved all query string serialization in payment api to 'serde_qs' Jan 11, 2021
Wiezzel
Wiezzel previously approved these changes Jan 12, 2021
View reviewed changes
Base automatically changed from event-api/master to master January 13, 2021 09:43
@tworec tworec dismissed Wiezzel’s stale review January 13, 2021 09:43

The base branch was changed.

Wiezzel
Wiezzel previously approved these changes Jan 13, 2021
View reviewed changes
@Wiezzel Wiezzel merged commit c8a671b into master Jan 13, 2021
@Wiezzel Wiezzel deleted the mwu/extract-params branch January 13, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wiezzel Wiezzel Wiezzel approved these changes

@pnowosie pnowosie Awaiting requested review from pnowosie

Assignees

@maaktweluit maaktweluit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maaktweluit @Wiezzel