Version/service #961
Merged
Version/service #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiivan
reviewed
Jan 22, 2021
tworec
force-pushed
the
version/service
branch
from
4d0cf6f
to
c829ff4
Compare
tworec
force-pushed
the
version/service
branch
from
db72969
to
8de9732
Compare
tworec
force-pushed
the
version/service
branch
from
35d318b
to
ad5fa7e
Compare
tworec
force-pushed
the
version/service
branch
from
3b1693f
to
98dea9f
Compare
jiivan
reviewed
Jan 25, 2021
core/version/src/github.rs
Outdated
| Err(e) => log::error!("Storing new Yagna release {} to DB. {}", rel, e), | ||
| Ok(r) => { | ||
| counter!("version.new", 1); | ||
| log::warn!("{}", ReleaseMessage::Available(&r)); |
There was a problem hiding this comment.
I don't like the idea of claiming pinger responsibility here. It can result in ugly spamming of log more frequently than defined by interval in pinger.
There was a problem hiding this comment.
this will be invoked:
- every 24h by
worker - on every start
- manually via
yagna version check
It will immediately inform the user (via logs) that there is new version. This immediate notification was my goal here.
The same message will be logged by pinger every 30mins.
There was a problem hiding this comment.
So every 24h we will get double logs from pinger and worker?
jiivan
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.