ZkSync driver: cron job mutexes #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a new payment scheduling job started while a previous one had been already in progress, it would lead to database errors due to single transaction being processed twice. Introduced mutexes for payment scheduling job and payment confirmation job to avoid it. Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
maaktweluit
approved these changes
Jan 28, 2021
|
I believe these two jobs should not interfere. They don't in zkSync driver at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a new payment scheduling job started while a previous one had been already in progress, it would lead to database errors due to single transaction being processed twice. Introduced mutexes for payment scheduling job and payment confirmation job to avoid it.