Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix blender.py example on python3.6 #667

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Conversation

shadeofblue
Copy link
Collaborator

closes #662

@shadeofblue shadeofblue requested a review from a team September 17, 2021 13:18
@shadeofblue shadeofblue self-assigned this Sep 17, 2021
Copy link
Contributor

@johny-b johny-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
But.
Shouldn't this have been detected by one of our CI tests? I'm confused.

@filipgolem
Copy link
Contributor

Nice.
But.
Shouldn't this have been detected by one of our CI tests? I'm confused.

Integration tests are using Python 3.8: https://github.com/golemfactory/yapapi/blob/master/.github/workflows/goth.yml; unit tests, typechecking, codestyle etc. are run on every OS/Python version combination: https://github.com/golemfactory/yapapi/blob/master/.github/workflows/tests.yml

@filipgolem filipgolem self-requested a review September 18, 2021 10:13
@shadeofblue
Copy link
Collaborator Author

Shouldn't this have been detected by one of our CI tests? I'm confused.

as @filipgolem already said, we currently run the goth tests only on Python 3.8 ... maybe we could enable the requestor code within those tests to use other python versions but that certainly is a separate tasks which would also include scheduling when such tests should be running (nightly only?) if feasible

@shadeofblue shadeofblue merged commit 36c2235 into master Sep 21, 2021
@shadeofblue shadeofblue deleted the blue/blender-python3.6-fix branch September 21, 2021 07:18
@johny-b
Copy link
Contributor

johny-b commented Sep 21, 2021

@filipgolem do you understand why mypy didn't detect this?

@filipgolem
Copy link
Contributor

@filipgolem do you understand why mypy didn't detect this?

Are we using mypy like this: mypy --python-version 3.6?
f" --- {ctx.provider_name} STATE: {await ctx.get_raw_state()}" is a valid Python 3.8 expression.

Probably related:
python/mypy#2622 (comment)
Also:
python/mypy#2265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weird SyntaxError: invalid syntax
3 participants