Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(2024.6.0): Handling time zones without blocking the event loop #153

Merged

Conversation

golles
Copy link
Owner

@golles golles commented Jun 4, 2024

https://developers.home-assistant.io/blog/2024/05/19/fix_zoneinfo_blocking_io/

Until 2024.6.0 is released, this fix uses 2024.6.0b6
Fix tests for unloading custom component (home-assistant/core#117214)

Until `2024.6.0` is released, this fix uses `2024.6.0b6`
Fix for unloading custom component
@golles golles linked an issue Jun 4, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2fb9d66) to head (87a0c9a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          377       376    -1     
=========================================
- Hits           377       376    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hacs.json Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@hmmbob
Copy link
Contributor

hmmbob commented Jun 4, 2024

If you're able to make this a beta release/pre-release, I could test it for you on HA b7

@golles
Copy link
Owner Author

golles commented Jun 5, 2024

Made a pre-release 2.2.0-b1 containing the fix.

I can't merge this yet, as https://github.com/MatthewFlamm/pytest-homeassistant-custom-component/releases has not released a compatible version for HA 2024.6.0 yet, it should be there tomorrow morning

@hmmbob
Copy link
Contributor

hmmbob commented Jun 6, 2024

Confirming that the beta fixes the issue in 2024.6.0

Copy link

sonarcloud bot commented Jun 6, 2024

@golles golles merged commit 1ce0708 into main Jun 6, 2024
8 checks passed
@golles golles deleted the 152-detected-blocking-call-to-open-inside-the-event-loop-ha-20246 branch June 6, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detected blocking call to open inside the event loop (HA 2024.6)
2 participants