Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead link in the help panel to EmojiOne demo #1775

Closed
julianbarg opened this issue Oct 23, 2021 · 2 comments · Fixed by #1845
Closed

Dead link in the help panel to EmojiOne demo #1775

julianbarg opened this issue Oct 23, 2021 · 2 comments · Fixed by #1845
Assignees
@benjaminwil

Comments

@julianbarg
Copy link

Describe the bug
There is a dead link in the Help panel--the link to the EmojiOne demo does not work anymore: http://emojione.com/demo/

To Reproduce

  1. Go to edit mode
  2. Click on the "?" to open the help panel
  3. Click on "Miscellaneous" on the left
  4. Click on Emoji
  5. Click on the link to the EmojiOne demo
@benjaminwil benjaminwil self-assigned this Oct 29, 2021
@benjaminwil
Copy link
Member

Thanks for reporting this. I'll update this issue once I've resolved the issue.

benjaminwil added a commit that referenced this issue Aug 14, 2022
@benjaminwil
Remove dead link from Markdown help pane
0a2f337 
In the editor, the help text for "Emoji" included a dead link. This
changes the link to a non-dead link.

After changing the JS, assets needed to be recompiled.

Resolves #1775.
benjaminwil added a commit that referenced this issue Aug 14, 2022
@benjaminwil
Remove dead link from Markdown help pane
55e49f9 
In the editor, the help text for "Emoji" included a dead link. This
changes the link to a non-dead link.

After changing the JS, assets needed to be recompiled.

Resolves #1775.
@benjaminwil benjaminwil mentioned this issue Aug 14, 2022
Merged
benjaminwil added a commit that referenced this issue Sep 22, 2022
@benjaminwil
Remove dead link from Markdown help pane
101bcfb 
In the editor, the help text for "Emoji" included a dead link. This
changes the link to a non-dead link.

After changing the JS, assets needed to be recompiled.

Resolves #1775.
benjaminwil added a commit that referenced this issue Sep 22, 2022
@benjaminwil
Remove dead link from Markdown help pane
aac6c9d 
In the editor, the help text for "Emoji" included a dead link. This
changes the link to a non-dead link.

After changing the JS, assets needed to be recompiled.

Resolves #1775.
@benjaminwil
Copy link
Member

Will be live in the next version of Gollum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaminwil benjaminwil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve editor "Help" functionality gollum/gollum
2 participants
@benjaminwil @julianbarg