Gollum::Wiki.pages hangs indefiniently

[henrikh]

The method pages hangs indefiniently when used on my computer. Using Git Bisect I've tracked the error to the commit http://github.com/github/gollum/commit/e37a8b9da473cb0301d40be28b72e15b0bee31d1

To reproduce:

• Open a Gollum "repo" with ruby [pathpath] --irc
• Enter wiki.pages
• Now it should hang there indefiniently

On any previous commit, the method would return a list of all pages.

I'm interested in knowing if anyone else can reproduce this bug.

[technoweenie]

How many pages is it returning? It's calling #title too, so it's parsing the title out of the formatted page. It's pretty important for the page index, otherwise you get pages out of order. Though, it's probably best to remove that code because basic gollum repos don't cache the formatted output. We cache all of that on GitHub, so I never noticed any performance hits.

[henrikh]

My computer might be slow (it is), but it takes about one minute to serve the list of pages.

[technoweenie]

For how many pages?

[henrikh]

25 pages

[henrikh]

I've "fixed" it on my branch pages_sorted_by_title

[technoweenie]

Cool. I'll probably just remove the code and leave it as an exercise of the user to sort stuff. I hear ruby can do that pretty easily :) Thanks for the report!

[technoweenie]

Henrikh: I just reverted the commit: dd7dddd