test_asciidoc_header fails on rhel6

[dekimsey]

The test_asciidoc_header test fails. The following is the output of the test:

Test Output

$ git checkout v2.4.0 
Previous HEAD position was 5f4d312... Added test for ASCII characters in code blocks created with back ticks.
HEAD is now at df75d2d... Release 2.4.0
$ ruby -I test test/test_markup.rb -n test_asciidoc_header
Loaded suite test/test_markup
Started
F
Finished in 0.059819 seconds.

  1) Failure:
test_asciidoc_header(Markup)
    [test/test_markup.rb:817:in `compare'
     test/test_markup.rb:791:in `test_asciidoc_header'
     /home/dekimsey/gollum-gems/gems/mocha-0.12.7/lib/mocha/integration/test_unit/ruby_version_186_and_above.rb:22:in `__send__'
     /home/dekimsey/gollum-gems/gems/mocha-0.12.7/lib/mocha/integration/test_unit/ruby_version_186_and_above.rb:22:in `run']:
<"<divclass=\"sect1\"><h2id=\"wiki-_heading\">Heading<aclass=\"anchor\"id=\"Heading\"href=\"#Heading\"></a></h2><divclass=\"sectionbody\"></div></div>"> expected but was
<"=BookTitle==Heading">.

1 tests, 1 assertions, 1 failures, 0 errors

Git Bisect Ouput

running ruby -I test test/test_markup.rb -n test_asciidoc_header
Loaded suite test/test_markup
Started
F
Finished in 0.054965 seconds.

  1) Failure:
test_asciidoc_header(Markup)
    [test/test_markup.rb:623:in `compare'
     test/test_markup.rb:596:in `test_asciidoc_header'
     /home/dekimsey/gollum-gems/gems/mocha-0.12.7/lib/mocha/integration/test_unit/ruby_version_186_and_above.rb:22:in `__send__'
     /home/dekimsey/gollum-gems/gems/mocha-0.12.7/lib/mocha/integration/test_unit/ruby_version_186_and_above.rb:22:in `run']:
<"<divclass=\"sect1\"><h2id=\"wiki-_heading\">Heading</h2><divclass=\"sectionbody\"></div></div>"> expected but was
<"=BookTitle==Heading">.

1 tests, 1 assertions, 1 failures, 0 errors
d1cf698b456cd6a35a54c6a8e7b41d3068acec3b is the first bad commit
commit d1cf698b456cd6a35a54c6a8e7b41d3068acec3b
Author: Ryan Fowler <ryan.fowler@singlewire.com>
Date:   Tue May 1 11:43:27 2012 -0500

    Disable internal link processing for asciidoc

    asciidoc's representation of section identifiers interferes with
    Gollum's page linking. This disables Gollum's page link tag
    extraction for asciidoc files.

    Adds "apt-get install -y asciidoc" to .travis.yml so tests pass
    on @travis-ci.

:100644 100644 6b66fd473f31d9044e600784b656185cfcda67e9 60f5d4890c6862a3f1295b422e205bed5a6d7221 M      .travis.yml
:040000 040000 c06180462406d9bd8f259627c8273706202c271d e5cfd81f56538fbd7724143e34a8b15a901baa76 M      lib
:040000 040000 4807caa17e3f2d202b8cc8d6a735e4e6f264d134 b11853df0abaa173b487b602d8a985f8ac5ede1c M      test
bisect run success

System Info

$ uname -a
Linux magic-server-box.com 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 EDT 2012 x86_64 x86_64 x86_64 GNU/Linux
$ ruby --version 
ruby 1.8.7 (2011-06-30 patchlevel 352) [x86_64-linux]
$ gem list
*** LOCAL GEMS ***

activesupport (3.2.8)
builder (3.1.4)
bundle (0.0.1)
bundler (1.2.1)
coderay (1.0.8)
diff-lcs (1.1.3)
expression_parser (0.9.0)
fcgi (0.8.8)
flexmock (0.8.6)
github-markdown (0.5.3)
github-markup (0.7.4)
gollum (2.4.0)
grit (2.5.0)
i18n (0.6.1)
metaclass (0.0.1)
method_source (0.8.1)
mime-types (1.19)
mocha (0.12.7)
multi_json (1.3.7)
mustache (0.99.4)
nokogiri (1.5.5)
org-ruby (0.7.2)
posix-spawn (0.3.6)
pry (0.9.10)
pygments.rb (0.3.2)
rack (1.4.1)
rack-protection (1.2.0)
rack-test (0.6.2)
rake (0.9.2.2, 0.8.7)
rake-compiler (0.7.9)
rb-readline (0.4.2)
RedCloth (4.2.9)
rubypants (0.2.0)
sanitize (2.0.3)
shoulda (3.3.2)
shoulda-context (1.0.1)
shoulda-matchers (1.4.1)
sinatra (1.3.3)
slop (3.3.3)
stringex (1.4.0)
tilt (1.3.3)
useragent (0.4.13, 0.4.12)
wikicloth (0.8.0)
yajl-ruby (1.1.0)

[dekimsey]

There are a couple other failing tests, I ran out of time (sunset being what it is) to report them today. Expect two more failing test reports tomorrow.

[bootstraponline]

The asciidoc tests are written against a very specific version of asciidoc (the version that runs on Travis CI). It's expected that they fail on other systems with a different version of asciidoc. For example, they failed on CloudBees BuildHive.

[dekimsey]

Does Ruby have a decent way of inquiring about a package's version? I'd like to fix the test then to generate an expected failure (if the rack test framework can do that) or skip it altogether. If the test is expected to only work on specific versions it should express that.

[bootstraponline]

Does Ruby have a decent way of inquiring about a package's version?

Not that I know of. Chef can do it but that seems a bit much for this.

I'd like to fix the test then to generate an expected failure (if the rack test framework can do that) or skip it altogether. If the test is expected to only work on specific versions it should express that.

I agree but I'm not sure of an easy way to do that.

[bootstraponline]

One solution could be to limit the AsciiDoc tests to only run if an ENV var is set and then set that ENV var on Travis CI.

[bootstraponline]

Fixed in 2.4.1.