Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary content in overview page #2043

Merged
merged 1 commit into from Apr 21, 2024
Merged

Remove unnecessary content in overview page #2043

merged 1 commit into from Apr 21, 2024

Conversation

zoumingzhe
Copy link
Contributor

Link #2042

benjaminwil
benjaminwil approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@benjaminwil benjaminwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@benjaminwil
Copy link
Member

Thanks for the contribution.

It looks like this change has caused some tests to fail, because we previously expected the text "Home" to appear and now that does not happen.

Are you able to push a commit to remove the offending tests?

@zoumingzhe
Copy link
Contributor Author

Are you able to push a commit to remove the offending tests?

I'm going to do this.

@benjaminwil benjaminwil merged commit 84fe196 into gollum:master Apr 21, 2024
6 checks passed
@zoumingzhe zoumingzhe deleted the overview branch April 23, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminwil benjaminwil benjaminwil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zoumingzhe @benjaminwil