page.raw_data not get converted to utf-8

[buger]

After switching to rugged adapter i started getting incompatible character encodings: ASCII-8BIT and UTF-8 errors and found that page.raw_data is returned in ASCII-8BIT encoding (was utf-8 using grit). I guess this should be converted inside adapter.

[dometto]

Thanks @buger, we'll be sure to address this before the first non-beta release.

[bartkamphorst]

The ASCII-8BIT encoding is set on purpose in rugged "since Git is encoding agnostic". See here. It would seem that in some instances page#text_data (see here) would be preferable over page#raw_data. @buger Do you recall which call to page.raw_data was giving you trouble?

[dometto]

It does seem to me like this shoud be handled by replacing #raw_data calls in gollum-lib to #text_data calls. It seems ok that the adapter just returns blob contents in ASCII-8. Should we close this and open a gollum-lib issue, @bartkamphorst?

[dometto]

Hmm, on second thought, it seems like and gollum and gollum-lib already use text_data when it comes to displaying the contents of a page. raw_data is used when showing the contents of a non-page file (which is arguably good), and in the following places:

• https://github.com/gollum/gollum/blob/master/lib/gollum/app.rb#L526-L533
• https://github.com/gollum/gollum-lib/blob/master/lib/gollum-lib/wiki.rb#L397
• https://github.com/gollum/gollum-lib/blob/master/lib/gollum-lib/filter/remote_code.rb#L25

Not sure if it should be changed in any of those places.

[bartkamphorst]

Exactly. Which is why I wanted to know which call specifically was causing trouble. :)

[dometto]

Agree. Ping @buger, can you help us reproduce your issue/point to the raw_data call in question?

[buger]

sure, I'll try to re-create test case

[bartkamphorst]

@buger Any luck re-creating a test case?

[buger]

Sorry, but I'm not working on this project anymore

On Wednesday, 31 August 2016, Bart Kamphorst <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

@buger https://github.com/buger Any luck re-creating a test case?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA2uVsap43KX2JU94DTZKlz0msbiOYRks5qldQDgaJpZM4DoumK
.

---

https://goreplay.org - test your system with real data
@buger https://twitter.com/buger - me on twitter

[dometto]

This should be resolved in 5.x, at least utf-8 contents are displaying fine. Closing because of no further info on how to reproduce.