Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest to upgrade to next version v1.2.x #20

Closed
wants to merge 78 commits into from
Closed

Suggest to upgrade to next version v1.2.x #20

wants to merge 78 commits into from

Conversation

chinmobi
Copy link

About the pull request, I've completed the following major works:

  1. Refactor the original config.go to three parts: base.go, config.go, and env.go, to achieve single-responsibility principle for each part.

  2. As the lookup() method is the key method to retrieve value by key, I update it for a bit performance consideration.

  3. Refactor the original config.New() method to pure New() method and the NewWithListener() method.

  4. (IMPORTANT) Add assign functions (and methods) to retrieve whole struct fields' value and/or whole slice elements' value

  5. All of the changes have passed the old tests.

  6. The added assigned utilities have passed the additional tests.

@YuZhaoping
Refine the EnvConfig from the Config
7c430ff
@YuZhaoping
Refine the ConfigBase from the Config
0afa9b5
@YuZhaoping
Refactor the Config with the EnvConfig
dd530e1
@YuZhaoping
Refactor the Config with the ConfigBase
a5a837e
@YuZhaoping
Refactor: move the RWMutex from ConfigBase to Config
9aba842
@YuZhaoping
Fix: resolve the Reload()'s goroutine safe issue
6f491ca
@YuZhaoping
Refactor: add the ConfigBase.init() method
9c4374a
@YuZhaoping
Refactor: the Config's New() and StartListener()
75eca24
@YuZhaoping
Add the Env() method for conveniently using
4c34292
@YuZhaoping
Add the Base() method for conveniently using
11fcdbe
@YuZhaoping
Add the AssignStruct methods to retrieve whole struct fields' value
9c37ed2
@YuZhaoping
Refactor the checkPtr() method to be reused
2dd21a0
@YuZhaoping
Polish the test AssignStruct methods' name
4e94697
@YuZhaoping
Refactor: add the assign_utils for common assign methods
b35af36
@YuZhaoping
Refactor: refine assign_struct method from the assign method
acf1994
@YuZhaoping
Refactor: rename the prepareData to prepareStructData
f0eedcd
@YuZhaoping
Add the AssignSlice methods to retrieve whole slice elements' value
118d5fd
@YuZhaoping
Add the AssignStruct methods to retrieve whole struct fields' value
33cb126
@YuZhaoping
Add the AssignStruct methods to retrieve whole struct fields' value
f9ce52e
@YuZhaoping
Fix: struct's slice field assignment
0713948
@YuZhaoping
Fix: pointer to interface
fbcd826
@YuZhaoping
Polish: change the assign tests to config_test package
2075256
@YuZhaoping
Refactor: Move the assign functions toe the assign package
48443bf
@YuZhaoping
Refine the EnvConfig from the Config
8055274
@YuZhaoping
Refine the ConfigBase from the Config
464603f
@YuZhaoping
Rebase to the master
bc16603
@YuZhaoping
Add the AssignStruct methods to retrieve whole struct fields' value
7c445dd
@YuZhaoping
Refactor the checkPtr() method to be reused
e6ebac6
@YuZhaoping
Polish the test AssignStruct methods' name
0faf222
@YuZhaoping
Refactor: add the assign_utils for common assign methods
965e0d1
@YuZhaoping
Refactor: refine assign_struct method from the assign method
78d25fa
@YuZhaoping
Refactor: rename the prepareData to prepareStructData
c65120c
@YuZhaoping
Add the AssignSlice methods to retrieve whole slice elements' value
f421759
@YuZhaoping
Add the AssignStruct methods to retrieve whole struct fields' value
6927f54
@YuZhaoping
Add the AssignStruct methods to retrieve whole struct fields' value
3aa1721
@YuZhaoping
Fix: struct's slice field assignment
3304b14
@YuZhaoping
Fix: pointer to interface
78f7fd0
@YuZhaoping
Polish: change the assign tests to config_test package
cb32b60
@YuZhaoping
Refactor: Move the assign functions toe the assign package
660927e
@YuZhaoping
Add the Env() method for conveniently using
52b9d56
@YuZhaoping
Add the Base() method for conveniently using
2fe0d32
@YuZhaoping
Add the AssignStruct methods to retrieve whole struct fields' value
202fcb3
@YuZhaoping
Refactor the checkPtr() method to be reused
74c763c
@YuZhaoping
Polish the test AssignStruct methods' name
b9970f7
@YuZhaoping
Refactor: add the assign_utils for common assign methods
b4f23ab
@YuZhaoping
Refactor: refine assign_struct method from the assign method
fd26f43
@YuZhaoping
Refactor: rename the prepareData to prepareStructData
ee43158
@YuZhaoping
Add the AssignSlice methods to retrieve whole slice elements' value
f3951c9
@YuZhaoping
Add the AssignStruct methods to retrieve whole struct fields' value
87ba73e
@YuZhaoping
Add the AssignStruct methods to retrieve whole struct fields' value
0c7e74c
@YuZhaoping
Fix: struct's slice field assignment
495c7c0
@YuZhaoping
Fix: pointer to interface
9becbec
@YuZhaoping
Polish: change the assign tests to config_test package
2478117
@YuZhaoping
Refactor: Move the assign functions toe the assign package
314055a
@YuZhaoping
Update the .travis.yml to include assign tests
6dab6dd
@YuZhaoping
Rename doFeedEnv to feedEnvItems
fd1a7c8
@YuZhaoping
Rename doFeed to feedItems
db96207
@YuZhaoping
Merge branch 'develop' of chinmobi-github:chinmobi/config into develop
fc4c8de
@miladrahimi
Copy link
Member

There is very nice features. Could you please separate them into separate branches (pull-requests) and make it compatible with the version 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chinmobi @miladrahimi @YuZhaoping