Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all key combinations get registered correctly #20

Open
golota60 opened this issue Sep 14, 2023 · 2 comments
Open

Not all key combinations get registered correctly #20

golota60 opened this issue Sep 14, 2023 · 2 comments
Labels
bug Something isn't working upstream

Comments

@golota60
Copy link
Owner

On win10, there seems to be an issue with 1) numpad inputs 2) combo inputs #16 (comment)

thanks @falkenhawk for reporting this 🙇

@falkenhawk
Copy link

As suggested in #16 (comment) to take values for keys and their combinations from https://www.electronjs.org/docs/latest/api/accelerator I've tried the following combinations by entering them in idasen-tray-config.json and restarting the app:

  • P - works ✔
  • Alt+P - works ✔
  • Shift+P - works ✔
  • AltGr+P - doesn't work ❌
  • Meta+J - doesn't work ❌
  • Super+J - doesn't work ❌
  • Control+J - works ✔
  • CommandOrControl+J - works ✔
  • Shift+Control+J - works ✔
  • numdiv - doesn't work ❌
  • nummult - doesn't work ❌
  • * - doesn't work ❌
  • 0 - works ✔
  • num0 - doesn't work ❌
  • Up - works ✔
  • Shift+Control+Alt+Up - works ✔👀

@golota60 golota60 added this to the v0.0.7 milestone Nov 22, 2023
@golota60 golota60 added the bug Something isn't working label Nov 22, 2023
@golota60
Copy link
Owner Author

golota60 commented Dec 23, 2023

Alright, so I've worked on this on and off for a couple of days, and I think there's not much to be done for now(except fixing frontend keyboard inputs on macOS/win10(? - cannot really speak for win10 as i really cannot find a machine running win10 anywhere) - which will be a part of 0.1.0).

Fixing the behaviors described here(ty for that btw 🙇 ) is more troublesome though. The shortcuts are managed by the upstream framework tauri, but it's pretty inconsistent with what it supports - the feature parity with electron seems to just not be there yet. For example Meta/Super/Numpad/AltGr behaviors simply just do not work, and since the keyboard handler API is pretty low-level and fully handled by the framework, the current fix is either waiting for the folks to fix that in the upstream framework, or having keystrokes be handled via external library on a different process - which is a pretty major change.

I'll try to file an issue upstream in the following days, but unfortunately, there's not much fixing to be done to this as of now. I will keep this open, as I assume tauri v2 will have most of this fixed, and I'll get back to this issue then. In the meantime, I'll try the more complicated workaround fixes, but it's unclear if they will be viable🤞. Anyways, they will not be a part of 0.1.0

Another thing I'll do is have an entry in the README.md explaining manual shortcuts so people can try to fix-up any cross-system weirdness themselves, as this feature really seems to be unstable in the framework, and I cannot provide any guardrails to ensure everything will work

@golota60 golota60 removed this from the v0.1.0 milestone Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

2 participants