feat: close not hide #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert of #31
turns out, hiding windows doesn't solve anything either, as there's no rust callback to notify about a window being hidden. This could've been solved by creating a custom rust command to handle the callback, but hiding windows has already been a workaround, and making a workaround on top of a workaround, is one level too deep for me.
If closing really turns out to be unsalvageable, i'll revert back to hiding. If it comes to that, i'll also need to do some perf tests on hiding vs closing, as we do not want to consume too much of end users' memory