Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples]: Write examples for the docs #30

Closed
apoorvcodes opened this issue Feb 9, 2022 · 7 comments · Fixed by #33
Closed

[Examples]: Write examples for the docs #30

apoorvcodes opened this issue Feb 9, 2022 · 7 comments · Fixed by #33
Assignees
Labels
📑documentation Improvements or additions to documentation 📈enhancement New feature or request 🆘help wanted Extra attention is needed

Comments

@apoorvcodes
Copy link
Member

apoorvcodes commented Feb 9, 2022

Describe the solution you'd like
So basically docgen is now configured to read @example tags so we will like to have some examples in the docs

Describe alternatives you've considered
An alternative can be ignoring them and having em on the guide but it wouldnt be suited tbh

@apoorvcodes apoorvcodes added the 📈enhancement New feature or request label Feb 9, 2022
@apoorvcodes
Copy link
Member Author

Any volunteers for the feature request @booleanrecep @megatank58 @savioxavier @scientific-dev

@apoorvcodes apoorvcodes added 🆘help wanted Extra attention is needed 📑documentation Improvements or additions to documentation labels Feb 9, 2022
@megatank58
Copy link
Contributor

I don't think it's good to add @example tag for every documentation, it will just add more lines, instead we can add comments only for necessary functions which are vague in explanation or which have too many configuration option

@booleanrecep
Copy link
Contributor

Any volunteers for the feature request @booleanrecep @megatank58 @savioxavier @scientific-dev

@apoorvcodes I am pretty intrested. For my current beginner knowledge It would be difficult for me to decide with what feature to deal. If you just give me a shortly discribed task I will happily get involved to code it

@apoorvcodes
Copy link
Member Author

Oh okay thanks for your interest @booleanrecep, I'll soon explain you the task

@apoorvcodes
Copy link
Member Author

@booleanrecep @megatank58 @savioxavier This is on hold cos m working on looking to squeeze out some more performance through hash table

@apoorvcodes
Copy link
Member Author

I don't think it's good to add @example tag for every documentation, it will just add more lines, instead we can add comments only for necessary functions which are vague in explanation or which have too many configuration option

I kinda agree

@apoorvcodes
Copy link
Member Author

With #33 pr we will have new hash implementation which makes us like 10x faster at scale, and I'll be doing the comments

@apoorvcodes apoorvcodes linked a pull request Feb 13, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📑documentation Improvements or additions to documentation 📈enhancement New feature or request 🆘help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants