feat(router): adapt to new hash table implementation #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: headers and docs
It is still not linked to the proper router implementation
|
#30 Ig we can work on this issue now |
megatank58
changed the title
megatank58
approved these changes
Feb 12, 2022
megatank58
pushed a commit
that referenced
this pull request
Feb 15, 2022
* feat(router): adapt to new hash table implementation (#33) * New router implementation It is still not linked to the proper router implementation * Swap mux implementation to use new routes Co-authored-by: Apoorv <tofu.develops@gmail.com> * feat: UseRouter with new router implementation * feat: Mount with new router implementation * feat: custom notfound handler * chore: remove useless code * feat: documentation for mux * fix: bug in route matching * chore: remove useless code * feature: support /path/:var/fixed/:var2 paths Previously matching fixed parts after a variable was not supported. Note: When two routes can match the same path the first one will be used. For example, if these two routes are registered: * `/path/:var/:var3/:var2` * `/path/:var/fixed/:var2` The path `/path/one/fixed/two` will match the first route. * chore: mux documentation * chore: remove query param from readme * chore: documentation cleanup Co-authored-by: Javi Fontan <jfontan@gmail.com> Co-authored-by: ToTu-Dev <75479355+ToTu-Dev@users.noreply.github.com>
megatank58
pushed a commit
that referenced
this pull request
Feb 16, 2022
* feat(router): adapt to new hash table implementation (#33) * New router implementation It is still not linked to the proper router implementation * Swap mux implementation to use new routes Co-authored-by: Apoorv <tofu.develops@gmail.com> * feat: UseRouter with new router implementation * feat: Mount with new router implementation * feat: custom notfound handler * chore: remove useless code * feat: documentation for mux * fix: bug in route matching * chore: remove useless code * feature: support /path/:var/fixed/:var2 paths Previously matching fixed parts after a variable was not supported. Note: When two routes can match the same path the first one will be used. For example, if these two routes are registered: * `/path/:var/:var3/:var2` * `/path/:var/fixed/:var2` The path `/path/one/fixed/two` will match the first route. * chore: mux documentation * chore: remove query param from readme * chore: documentation cleanup * feat: query can be donated with ?q in path * feat: no need of rawhandler * chore: readme fix * feat: added makefile * chore: remove duplicate methods * chore: no more query params * chore: fix review issues Co-authored-by: Javi Fontan <jfontan@gmail.com> Co-authored-by: ToTu-Dev <75479355+ToTu-Dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.