feat: add support for /path/:slug/path/:slug pattern in paths
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously matching fixed parts after a variable was not supported. Note: When two routes can match the same path the first one will be used. For example, if these two routes are registered: * `/path/:var/:var3/:var2` * `/path/:var/fixed/:var2` The path `/path/one/fixed/two` will match the first route.
megatank58
changed the title
/path/:slug/path/:slug pattern in paths
megatank58
requested changes
Feb 15, 2022
There was a problem hiding this comment.
The param struct needs minima documentation comments, rest LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously matching fixed parts after a variable was not supported.
Note: When two routes can match the same path the first one will be
used. For example, if these two routes are registered:
/path/:var/:var3/:var2/path/:var/fixed/:var2The path
/path/one/fixed/twowill match the first route.