Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add banner colors #53

Merged
merged 1 commit into from
Mar 6, 2022
Merged

feat: add banner colors #53

merged 1 commit into from
Mar 6, 2022

Conversation

savioxavier
Copy link
Member

This PR adds colors to the main Minima banner

This is what it should look like (at least with the One Dark Pro terminal theme)

image

Should work fine on zsh and Powershell. Colors might not be displayed correctly on Git Bash on Windows though, due to improper terminal configuration. To fix that, you could use a live-reloading command line utility such as Air and the issue should be fixed.

@apoorvcodes
Copy link
Member

can u attach an example

@apoorvcodes
Copy link
Member

wait u did m blind

@apoorvcodes
Copy link
Member

change the minima to dark blue or purple, purple prefered

@savioxavier
Copy link
Member Author

change the minima to dark blue or purple, purple prefered

Sure thing!

minima.go Show resolved Hide resolved
@savioxavier
Copy link
Member Author

change the minima to dark blue or purple, purple prefered

Sure thing!

Here you go, purple in One Dark Pro.
Will be different with different terminal color themes, of course.

image

Is this alright? I personally prefer the green though.

@apoorvcodes
Copy link
Member

change the minima to dark blue or purple, purple prefered

Sure thing!

Here you go, purple in One Dark Pro. Will be different with different terminal color themes, of course.

image

Is this alright? I personally prefer the green though.

try cyan?

@savioxavier
Copy link
Member Author

try cyan?

Uhh... too similar to the text below

image

@savioxavier
Copy link
Member Author

Should we go with green itself?

@megatank58
Copy link
Contributor

Green is fine.

@megatank58 megatank58 merged commit 6f8b199 into main Mar 6, 2022
@megatank58 megatank58 deleted the banner-colors-minima branch March 6, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants