Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded port #30

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove hardcoded port #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8058252
Remove hardcoded port
dsloanather Mar 31, 2023
42afdb1
updating version and values.yml
dsloanather Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/athens-proxy/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: athens-proxy
version: 0.5.9
version: 0.5.10
appVersion: v0.11.0
description: The proxy server for Go modules
icon: https://raw.githubusercontent.com/gomods/athens/main/docs/static/banner.png
Expand Down
3 changes: 0 additions & 3 deletions charts/athens-proxy/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ spec:
port: {{ .Values.service.servicePort }}
targetPort: 3000
protocol: TCP
{{- if eq .Values.service.type "NodePort" }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is backwards breaking and the NodePort should stay configurable.
The port is not hardcoded but set by default, IF service type is "NodePort" (which by default is "ClusterIP").

nodePort: {{ .Values.service.nodePort.port }}
{{- end }}
selector:
app: {{ template "fullname" . }}
release: "{{ .Release.Name }}"
3 changes: 0 additions & 3 deletions charts/athens-proxy/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ service:
## from within the cluster. To expose externally, consider a "NodePort" or "LoadBalancer" service.
type: ClusterIP
## Further configuration if service is of type "NodePort"
nodePort:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must stay, but may be commented out as it is only used when type: NodePort

## Available port in allowable range (e.g. 30000 - 32767 on minikube)
port: 30080

ingress:
enabled: false
Expand Down