fix: preprovisioned service account unable to be included in deployment #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Bartolomey <github@alexanderbartolomey.de>
Signed-off-by: Alexander Bartolomey <github@alexanderbartolomey.de>
DrPsychick
approved these changes
May 8, 2024
Signed-off-by: Alexander Bartolomey <github@alexanderbartolomey.de>
DrPsychick
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#71 excludes serviceAccounts in the deployment template entirely if
serviceAccount.enabledis set to false, meaning it defaults to "default" for the deployment. Previously, we could create a service account that was named identical tofullname, i.e., either the release name or an override via values, and have that SA be used for the pod.This PR re-adds the ability to use service accounts in the deployment without creating one, and also extends upon the pre-#71 behavior of allowing you to set the name of the service account to use via
serviceAccount.name. The property is not set in the chart's default values, and defaults to thefullnamebehavior of < v0.9.4.Additionally, we also swapped out a bunch of "templates" for "includes", as per https://helm.sh/docs/howto/charts_tips_and_tricks/#using-the-include-function.