Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Implement cataloger interface for Minio * Catalog fix * Implemented Catalog method in the Minio storage package * code fmt fix * fmt fix * remove unused channel
- Loading branch information
Showing
4 changed files
with
92 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
package minio | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"strings" | ||
|
||
"github.com/gomods/athens/pkg/errors" | ||
"github.com/gomods/athens/pkg/observ" | ||
"github.com/gomods/athens/pkg/paths" | ||
"github.com/minio/minio-go" | ||
) | ||
|
||
// Catalog implements the (./pkg/storage).Cataloger interface | ||
// It returns a list of modules and versions contained in the storage | ||
func (s *storageImpl) Catalog(ctx context.Context, token string, pageSize int) ([]paths.AllPathParams, string, error) { | ||
const op errors.Op = "minio.Catalog" | ||
ctx, span := observ.StartSpan(ctx, op.String()) | ||
defer span.End() | ||
queryToken := token | ||
res := make([]paths.AllPathParams, 0) | ||
startAfter := token | ||
token = "" | ||
|
||
count := pageSize | ||
for count > 0 { | ||
loo, err := s.minioCore.ListObjectsV2(s.bucketName, token, "", false, "", 0, startAfter) | ||
if err != nil { | ||
return nil, "", errors.E(op, err) | ||
} | ||
|
||
m, lastKey := fetchModsAndVersions(loo.Contents, count) | ||
|
||
res = append(res, m...) | ||
count -= len(m) | ||
queryToken = lastKey | ||
|
||
if !loo.IsTruncated { // not truncated, there is no point in asking more | ||
if count > 0 { // it means we reached the end, no subsequent requests are necessary | ||
queryToken = "" | ||
} | ||
break | ||
} | ||
} | ||
|
||
return res, queryToken, nil | ||
} | ||
|
||
func fetchModsAndVersions(objects []minio.ObjectInfo, elementsNum int) ([]paths.AllPathParams, string) { | ||
res := make([]paths.AllPathParams, 0) | ||
lastKey := "" | ||
|
||
for _, o := range objects { | ||
if !strings.HasSuffix(o.Key, ".info") { | ||
continue | ||
} | ||
|
||
p, err := parseMinioKey(&o) | ||
if err != nil { | ||
continue | ||
} | ||
|
||
res = append(res, p) | ||
lastKey = o.Key | ||
|
||
elementsNum-- | ||
if elementsNum == 0 { | ||
break | ||
} | ||
} | ||
return res, lastKey | ||
} | ||
|
||
func parseMinioKey(o *minio.ObjectInfo) (paths.AllPathParams, error) { | ||
const op errors.Op = "minio.parseMinioKey" | ||
parts := strings.Split(o.Key, "/") | ||
v := parts[len(parts)-2] | ||
m := strings.Replace(o.Key, v, "", -2) | ||
m = strings.Replace(m, "//.info", "", -1) | ||
if m == "" || v == "" { | ||
return paths.AllPathParams{}, errors.E(op, fmt.Errorf("invalid object key format %s", o.Key)) | ||
} | ||
return paths.AllPathParams{m, v}, nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters