Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helm chart] secrets keys should be set in a secret, not as clear text env in deployment #25

Closed
draeron opened this issue Sep 15, 2020 · 2 comments · Fixed by #7
Closed

[helm chart] secrets keys should be set in a secret, not as clear text env in deployment #25

draeron opened this issue Sep 15, 2020 · 2 comments · Fixed by #7
Milestone
0.6.0 - back to a...

Comments

@draeron
Copy link

draeron commented Sep 15, 2020

All secret keys (for aws, minio etc) should be in a external k8s secret instead of directly be as env variable.

https://github.com/gomods/athens/blob/main/charts/athens-proxy/templates/deployment.yaml#L103
@arschles
Copy link
Member

@draeron are you wanting to create a secret outside of the helm chart, and then bring it into your pod as an environment variable?

@draeron
Copy link
Author

draeron commented Nov 20, 2020

By external i meant the chart itself should create the secrets and the deployment should refer to it via a secretKeyRef.

@DrPsychick DrPsychick mentioned this issue Jan 27, 2023
Closed
This was referenced Mar 10, 2023
Closed
Merged
@DrPsychick DrPsychick transferred this issue from gomods/athens Mar 28, 2023
@DrPsychick DrPsychick added this to the 0.6.0 - back to awesomeness milestone Apr 1, 2023
DrPsychick added a commit that referenced this issue Apr 13, 2023
@DrPsychick @nrwiersma
feat: use secretKeyRef (#7)
1ee7d70 
closes gomods/athens#5 
closes #25
closes #24

---------

Co-authored-by: Nicholas Wiersma <nick@wiersma.co.za>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0 - back to awesomeness
Development

Successfully merging a pull request may close this issue.

fix: #5 use secretKeyRef
3 participants
@arschles @draeron @DrPsychick