-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the GoGet middleware configurable #44
Comments
I have some thoughts here, I need to formalize, I think there's more to this. |
Continuing conversation on slack, @bketelsen you formalized all (we think) of the possible CLI workflows (copied to here). The question that remains is whether 2.i will cause If it's the former, this doesn't matter as much. Otherwise, we need this so the server knows where to redirect |
here's the code from vgo:
zip, and other implementations are the same, they expect to call the proxy with the url. |
thanks @bketelsen - confirms my understanding too. reading the code cemented it too - good idea :) the GoGet middleware still needs to be configurable for registry use, but not for proxy usage |
* Using the CDN getter in the GoGet middleware Fixes #44 * Adding a fake CDN getter For use in stubbing and testing * Passing the CDN Getter into the GoGet middleware * Fixing template render
* Using the CDN getter in the GoGet middleware Fixes #44 * Adding a fake CDN getter For use in stubbing and testing * Passing the CDN Getter into the GoGet middleware * Fixing template render
You should be able to configure it to redirect to any DNS name or IP - including the proxy IP/name, if running in proxy mode. Right now, it's hard-coded to
gomods.io
The text was updated successfully, but these errors were encountered: