Fix sumdb/* paths when config.PathPrefix is set #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http.StripPrefix will look at the entire request path when called, if we do not include config.PathPrefix then the StripPrefix call will never receive a valid path from the application and the user will always get a 404 error. There were no test where I could easily check this regression so I also added a few endpoint tests, the last test will fail with a 404 instead of 403 if this change in not applied.
There was a problem hiding this comment.
@elliotmr thank you for the fix and the tests look great!
Just a few comments. Let me know if you're busy and I'm happy to apply them myself, but otherwise take your time.
Appreciate the contribution 🎉
Co-authored-by: Marwan Sulaiman <marwan-at-work@github.com>
Co-authored-by: Marwan Sulaiman <marwan-at-work@github.com>
Co-authored-by: Marwan Sulaiman <marwan-at-work@github.com>
Co-authored-by: Marwan Sulaiman <marwan-at-work@github.com>
|
All changes looked good to me, I used TrimRight instead of TrimSuffix because I forgot that it existed. |
marwan-at-work
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1619
http.StripPrefix will look at the entire request path when called,
if we do not include config.PathPrefix then the StripPrefix call
will never receive a valid path from the application and the user
will always get a 404 error.
There were no test where I could easily check this regression so
I also added a few endpoint tests, the last test will fail with
a 404 instead of 403 if this change in not applied.
What is the problem I am trying to address?
Describe the issue you have been trying to solve.
How is the fix applied?
Mention briefly how you have applied the fix.
What GitHub issue(s) does this PR fix or close?
Fixes #