Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GO111MODULE to auto in golint script– #1743 #1744

Merged
merged 3 commits into from
Dec 10, 2021

Commits on Dec 9, 2021

  1. Set GO111MODULE to auto in golint script– gomods#1743

    As mentioned in gomods#1743 the Go modules environment flag is set to `off`
    in the script which appears to cause a warning message for each module
    of the codebase that it is "not in GOROOT".
    
    Set to `auto` as this allows the same build to be run the original way
    should someone choose to delete the `go.mod` file from the project root.
    rbrtl committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    4572813 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Remove redundant code – golint script

    Go 1.17 ignores `GO111MODULE` and there are no directories in the
    project root called `mock`.
    rbrtl committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    61017a8 View commit details
    Browse the repository at this point in the history
  2. Replace golint with go vet

    `golint` is deprecated (and frozen) replace with the current `go vet`.
    This reported one issue on `main` branch:
    ```pkg/stash/with_etcd.go:33:28:
    loop variable ep captured by func literal```
    
    Fixed loop variable capture with extraction to parameterised anonymous
    function passed loop variable and passed in to `errgroup.Go` call.
    rbrtl committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    d76ace1 View commit details
    Browse the repository at this point in the history