Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lib/pq to fix cert permissions issues #1804

Merged
merged 2 commits into from Jan 30, 2023
Merged

Update lib/pq to fix cert permissions issues #1804

merged 2 commits into from Jan 30, 2023

Conversation

jorng
Copy link
Contributor

@jorng jorng commented Nov 30, 2022

What is the problem I am trying to address?

When attempting to connect to a PostgreSQL database using certificate credentials, authentication may fail due to permissions issues on the certificate files. When using Athens in Kubernetes, this issue may be unavoidable when using secrets.

How is the fix applied?

The github.com/lib/pq library has resolved this issue as of v1.10.6, so this commit updates that library to the latest release version (v1.10.7) to resolve the issue in Athens.

@jorng jorng requested a review from a team as a code owner November 30, 2022 22:17
Copy link
Contributor

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Run the tests on the PR as it is and rebased version.

When attempting to connect to a PostgreSQL database using certificate
credentials, authentication may fail due to permissions issues on the
certificate files. When using Athens in Kubernetes, this issue may be
unavoidable when using secrets.

The github.com/lib/pq library has resolved this issue as of v1.10.6, so
this commit updates that library to the latest release version (v1.10.7)
to resolve the issue in Athens.
Copy link
Member

@r-ashish r-ashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@r-ashish r-ashish merged commit 23bfcd1 into gomods:main Jan 30, 2023
@jorng jorng deleted the libpq-update branch January 30, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants