Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Publish multi-arch docker image (amd64 and arm64) #1862

Merged
merged 7 commits into from
May 4, 2023

Conversation

project0
Copy link
Contributor

What is the problem I am trying to address?

We want to switch our workload to arm64 (AWS Graviton) for improved cost-efficiency. One of the remaining images not proving arm64 compatible images is athens.

This PR supersede #1794 as the pipeline was moved to github actions

How is the fix applied?

extend github actions workflow

What GitHub issue(s) does this PR fix or close?

Fixes #

@DrPsychick
Copy link
Member

@project0 We'll take a look at this after the 0.12.0 version is released.

@DrPsychick DrPsychick added this to the 0.12.1 milestone Apr 1, 2023
@mloiseleur
Copy link
Contributor

Hello @DrPsychick ,

0.12.0 version has been released. Is the path clear to review this PR, now ?

@DrPsychick
Copy link
Member

Hey @mloiseleur, generally yes, we're on track now again the latest Athens.
Next up will be 0.12.1 with bugfixes (soon). I will take a look at this within the next 2 weeks.

cmd/proxy/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/release.latest.yml Outdated Show resolved Hide resolved
@project0 project0 requested a review from DrPsychick May 3, 2023 06:52
Copy link
Member

@DrPsychick DrPsychick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test this?

I cannot get it to run through on my fork, so please test it in your fork so that the actions actually run through.

Also, one minor thing: all other workflows use .yml extension, so keep it consistent please.

https://github.com/DrPsychick/athens/actions/runs/4869859787/jobs/8684877269

@project0
Copy link
Contributor Author

project0 commented May 3, 2023

@DrPsychick i am sorry, i should have tested it better. There seem to be some issues with re-usables here, so i decided to avoid them at the end.

@project0 project0 requested a review from DrPsychick May 3, 2023 12:45
Copy link
Member

@DrPsychick DrPsychick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor fix and we're good I think.

.github/workflows/release.canary.yml Outdated Show resolved Hide resolved
@justenwalker
Copy link

justenwalker commented May 3, 2023

Hey @project0 ; thanks for implementing this!

Perhaps we could also get arm64 builds in the .goreleaser.yml as well?

main...justenwalker:athens:jwalker/multi-arch-arm64#diff-42e26dc67aed8aa3edb2472b4403288c1699fb6dc47419b9a475f0f224fe4689

@project0 project0 requested a review from DrPsychick May 4, 2023 06:52
Copy link
Member

@DrPsychick DrPsychick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@DrPsychick DrPsychick merged commit e35007b into gomods:main May 4, 2023
@DrPsychick DrPsychick modified the milestones: 0.12.1, 0.13.0 May 7, 2023
@mloiseleur mloiseleur mentioned this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants