-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Publish multi-arch docker image (amd64 and arm64) #1862
Conversation
c91dd31
to
39af567
Compare
@project0 We'll take a look at this after the 0.12.0 version is released. |
Hello @DrPsychick , 0.12.0 version has been released. Is the path clear to review this PR, now ? |
Hey @mloiseleur, generally yes, we're on track now again the latest Athens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you test this?
I cannot get it to run through on my fork, so please test it in your fork so that the actions actually run through.
Also, one minor thing: all other workflows use .yml
extension, so keep it consistent please.
https://github.com/DrPsychick/athens/actions/runs/4869859787/jobs/8684877269
@DrPsychick i am sorry, i should have tested it better. There seem to be some issues with re-usables here, so i decided to avoid them at the end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor fix and we're good I think.
Hey @project0 ; thanks for implementing this! Perhaps we could also get arm64 builds in the .goreleaser.yml as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
dcd5f9c
to
7e3a2df
Compare
What is the problem I am trying to address?
We want to switch our workload to arm64 (AWS Graviton) for improved cost-efficiency. One of the remaining images not proving arm64 compatible images is athens.
This PR supersede #1794 as the pipeline was moved to github actions
How is the fix applied?
extend github actions workflow
What GitHub issue(s) does this PR fix or close?
Fixes #