Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax file permissions #1866

Merged
merged 1 commit into from Apr 14, 2023
Merged

fix: relax file permissions #1866

merged 1 commit into from Apr 14, 2023

Conversation

nrwiersma
Copy link
Contributor

@nrwiersma nrwiersma commented Apr 13, 2023

What is the problem I am trying to address?

This relaxes the permissible config file permission to allow read for group and other (effectively 0o644).

For reference, the current docker build sets the file permissions to 0o644.

How is the fix applied?

Changed the permission check and added a test for allowing 0o644.

What GitHub issue(s) does this PR fix or close?

Fixes #1007

@nrwiersma nrwiersma requested a review from a team as a code owner April 13, 2023 08:41
@nrwiersma nrwiersma self-assigned this Apr 13, 2023
Copy link
Member

@DrPsychick DrPsychick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@DrPsychick DrPsychick added this to the 0.12.1 milestone Apr 13, 2023
@nrwiersma nrwiersma merged commit 7c3e3a0 into gomods:main Apr 14, 2023
12 checks passed
@nrwiersma nrwiersma deleted the file-perm branch April 14, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config file permission
2 participants