implementing disk storage for the proxy #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
direction looks good to me. |
pkg/storage/disk/disk.go
Outdated
| // ListerSaver is the only interface defined by the disk storage. Use | ||
| // NewListerSaver to create one of these. Everything is all in one | ||
| // because it all has to share the same tree | ||
| type ListerSaver interface { |
There was a problem hiding this comment.
don't want to brag about naming so soon but can't this be just a Storage or StorageSystem? ListerSaver seems very weird to me
|
Fair enough! These interface names are all over the map; I’ll standardize.
…On Fri, Mar 2, 2018 at 06:53 Michal Pristas ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkg/storage/disk/disk.go
<#20 (comment)>:
> @@ -0,0 +1,41 @@
+package disk
+
+import (
+ "io/ioutil"
+ "path/filepath"
+
+ "github.com/gomods/athens/pkg/storage"
+)
+
+// ListerSaver is the only interface defined by the disk storage. Use
+// NewListerSaver to create one of these. Everything is all in one
+// because it all has to share the same tree
+type ListerSaver interface {
don't want to brag about naming so soon but can't this be just a Storage
or StorageSystem? ListerSaver seems very weird to me
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEU0c3IZHQgILLPpXBSd4RRzKds0s6lks5taVzVgaJpZM4SZK7o>
.
|
|
I can't place 👍 to a commit |
arschles
force-pushed
the
disk-storage
branch
3 times, most recently
from
676787a
to
94f57d7
Compare
It’s unnecessary
arschles
changed the title
bketelsen
approved these changes
Mar 8, 2018
pkg/storage/disk/all_test.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| mod = []byte("123") |
There was a problem hiding this comment.
maybe a note for future us that a wider variety of file sizes would be useful to catch possible edge cases - especially related to http and buffers, etc.
pkg/storage/disk/getter.go
Outdated
| "github.com/gomods/athens/pkg/storage" | ||
| ) | ||
|
|
||
| func (v *storageImpl) Get(baseURL, module, vsn string) (*storage.Version, error) { |
There was a problem hiding this comment.
nit: vsn is almost unclear, and version isn't too many more characters. Feel free to ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5