Proposal: move buffalo app to cmd #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added olympus app. on top of that |
michalpristas
force-pushed
the
move-buf-app
branch
from
1530f9b
to
a090b4c
Compare
|
Ref #87 @michalpristas this fixes #84, right? |
arschles
requested changes
Mar 26, 2018
cmd/olympus/actions/feed.go
Outdated
| func feedHandler(s storage.Storage) func(c buffalo.Context) error { | ||
| return func(c buffalo.Context) error { | ||
| _, err := getSyncPoint(c) | ||
| if err != nil { |
There was a problem hiding this comment.
can you combine these two lines together:
if _, err := getSyncPoint(c); err != nil {
...| @@ -0,0 +1,3 @@ | |||
| { | |||
| "presets": ["env"] | |||
| } | |||
There was a problem hiding this comment.
can you add a newline at the end of the file?
cmd/proxy/actions/storage.go
Outdated
| case "disk": | ||
| rootLocation, err := envy.MustGet("ATHENS_DISK_STORAGE_ROOT") | ||
| if err != nil { | ||
| return nil, fmt.Errorf("missing disk storage root (%s)", err) |
There was a problem hiding this comment.
I'd rather not rely on an environment variable this deep in the stack. Could you pass the root location as a param to the function? Same with below
| <% } %> | ||
| </div> | ||
| </div> | ||
| <% } %> |
|
merging this so we can move ahead without ugly conflicts. |
This was referenced Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to keep root of the repo clear, executables in cmd (cli, webs) shared code in /pkg
If this is not ok, i will abandon, i don't need to have it there, but it might be ok if we go with one repo for multiple buffalo apps (either olympus or registry)
Fixes: #108