New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing the "alpha" tag from the readme #977
Conversation
b/c we're now beta. also shortening a few other pieces of the readme
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
======================================
Coverage 59.8% 59.8%
======================================
Files 75 75
Lines 2356 2356
======================================
Hits 1409 1409
Misses 816 816
Partials 131 131 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question.
README.md
Outdated
|
||
Athens proxies are highly configurable, so they can work for lots of different deployments. For example, public proxies can store code in cloud databases and CDNs, while internal "enterprise" deployments can use disk-based (i.e. NFS) storage. | ||
Athens proxies are highly configurable, so they can work for lots of different deployments. For example, proxies support a wide variety of storage drivers like cloud blob storage systems, cloud CDNs, shared disk, and even in-memory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cloud CDNs
Could you explain what do you mean by that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll write it up in the docs
@@ -44,14 +42,14 @@ Speaking of contributing, read on! | |||
|
|||
# Contributing | |||
|
|||
This project is early and there's plenty of interesting and challenging work to do. | |||
This project has plenty of interesting and challenging work to do and a wonderful community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@marpio I changed up #977 (comment) a little bit, can you let me know what you think? |
Looks like all the comments have been addressed. I am merging it. Thanks @arschles, these are amazing docs. |
What is the problem I am trying to address?
The readme still says the project is in alpha, but it's in beta now
How is the fix applied?
I updated the stuff that says we're in alpha or "the project is early" etc...
Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.