Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RequestContext to PubSubConn #603

Merged
merged 1 commit into from Mar 23, 2022

Conversation

pabigot
Copy link
Contributor

@pabigot pabigot commented Mar 17, 2022

Add a wrapper that goes through the standard receiveInternal
processing to match the API of the existing PubSubConn Receive
methods.

Fixes: #592

redis/pubsub.go Outdated Show resolved Hide resolved
pabigot added a commit to pabigot/redigo that referenced this issue Mar 17, 2022
Add a wrapper that goes through the standard receiveInternal
processing to match the API of the existing PubSubConn Receive
methods.

Fixes: gomodule#592
@pabigot pabigot marked this pull request as ready for review Mar 17, 2022
pabigot added a commit to pabigot/redigo that referenced this issue Mar 17, 2022
Add a wrapper that goes through the standard receiveInternal
processing to match the API of the existing PubSubConn Receive
methods.

Fixes: gomodule#592
@pabigot
Copy link
Contributor Author

pabigot commented Mar 21, 2022

It doesn't seem that the design intent is to limit the features of PubSubConn, but an alternative approach that's only slightly less ideal would be to expose pubsub/receiveInternal as a visible, documented reply helper so we could do:

v := redis.PubSubReply(redis.ReceiveContext(c, ctx))

That might be useful anyway.

@pabigot pabigot changed the title feat: add RequestContext to PubSubConn (TBD) feat: add RequestContext to PubSubConn Mar 22, 2022
pabigot added a commit to pabigot/redigo that referenced this issue Mar 22, 2022
Add a wrapper that goes through the standard receiveInternal
processing to match the API of the existing PubSubConn Receive
methods.

Fixes: gomodule#592
redis/pubsub.go Outdated Show resolved Hide resolved
redis/pubsub_test.go Outdated Show resolved Hide resolved
pabigot added a commit to pabigot/redigo that referenced this issue Mar 23, 2022
Add a wrapper that goes through the standard receiveInternal
processing to match the API of the existing PubSubConn Receive
methods.

Fixes: gomodule#592
pabigot added a commit to pabigot/redigo that referenced this issue Mar 23, 2022
Add a wrapper that goes through the standard receiveInternal
processing to match the API of the existing PubSubConn Receive
methods.

Fixes: gomodule#592
Add a wrapper that goes through the standard receiveInternal
processing to match the API of the existing PubSubConn Receive
methods.

Fixes: gomodule#592
@stevenh stevenh merged commit 3eb0774 into gomodule:master Mar 23, 2022
1 check passed
@stevenh
Copy link
Collaborator

stevenh commented Mar 23, 2022

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants