Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ios category id naming issue and add support for send_rate #39

Merged
merged 3 commits into from Jan 7, 2016

Conversation

AhmedFawzy
Copy link
Contributor

http://docs.pushwoosh.com/docs/createmessage

Example:

"ios_category_id": "1", // Optional. Integer. iOS8 category ID from Pushwoosh
"send_rate": 100, // Throttling. Valid values are from 100 to 1000 pushes/second.

@bgaillard bgaillard added this to the 1.4.0 milestone Jan 7, 2016
@bgaillard bgaillard self-assigned this Jan 7, 2016
@bgaillard
Copy link
Member

Hi @AhmedFawzy and thanks for this, i'll merge this PR in few hours and create a new 1.4.0 version of the library.

@AhmedFawzy
Copy link
Contributor Author

thanks @bgaillard I am really waiting for it for an active project.
by the way, I loved you code go ahead man

bgaillard added a commit that referenced this pull request Jan 7, 2016
Fix ios category id naming issue and add support for send_rate
@bgaillard bgaillard merged commit b962ec2 into gomoob:master Jan 7, 2016
bgaillard added a commit that referenced this pull request Jan 7, 2016
send_rate ;
 * Test the IOS `getCategoryId()` and `setCategoryId($categoryId)`
functions ;
 * Add new Notification `preset`, `getPreset()` and `setPreset($preset)`
attribute and functions ;
 * Add new Notification `remotePage`, `getRemotePage()` and
`setRemotePage($remotePage)` attribute and functions ; 
 * Add new Notification `richPageId`, `getRichPageId()` and
`setRichPageId($richPageId)` attribute and functions ; 
 * Add new Notification `sendRate`, `getSendRate()` and
`setSendRate($sendRate)` attribute and functions ; 
 * Update composer dependencies.
@bgaillard
Copy link
Member

Done, in the same time we've also implemented other features (see the release notes https://github.com/gomoob/php-pushwoosh/releases/tag/1.4.0).

@AhmedFawzy if its not already done you can star our projet to help us even more 😄

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants