Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNG with ICC Profile breaks cache on x64 #2125

Closed
GhostlyDark opened this issue Nov 4, 2019 · 2 comments
Closed

PNG with ICC Profile breaks cache on x64 #2125

GhostlyDark opened this issue Nov 4, 2019 · 2 comments

Comments

@GhostlyDark
Copy link
Contributor

What's broken:
Certain PNG files cause a crash when trying to generate cache. It turns out that image files with a certain profile are causing this. ImageMagick puts this out:
iCCP: profile 'ICC Profile': 'GRAY': Gray color space not permitted on RGB PNG

Affected platforms:
This only happens with Project 64 (64-bit) and mupen64plus (64-bit) as this is not reproducable with their 32-bit counterparts. Tested on Windows 10 1903 x64.

Workaround:
Stripping the image or reexporting with GIMP fixes this.
Using GLideN64's 32-bit version instead works as well.

Reproduce:
ImageMagick Full Output
Test Images

gonetz added a commit that referenced this issue Nov 4, 2019
Fixed PNG with ICC Profile breaks cache on x64 #2125
@gonetz
Copy link
Owner

gonetz commented Nov 4, 2019

Fixed with 4b263e3
I tested mupen64plus x64 only.
The fix included into latest WIP build, #2037

The problem was really with that profile. pnglib tried to output into stderr the same warning about Gray color space, but console output crashes for some reason with x64 build, so I just disabled it.

@GhostlyDark
Copy link
Contributor Author

Grabbed the x64 mupen build from AppVeyor since the WIP build is a few hours too old.
I can confirm that it is fixed. Thank you again!

gonetz added a commit that referenced this issue Nov 5, 2019
Fixed PNG with ICC Profile breaks cache on x64 #2125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants