-
Notifications
You must be signed in to change notification settings - Fork 16
Fix and clean up comments in cblas64/128 #154
Conversation
I'm confused. Why does the build fail due to missing sqrt and why has the coverage increased? |
I don't have time to look into this for the next few days. Both things are mysterious. |
Has coverage increased because total line count has decreased? |
I don't get the coveralls UI, so I cannot confidently interpret it. My command line says:
|
The link failure isn't repeatable on my machine here, but a restart on travis shows it is there. Presumably libmath is not being specified somewhere that we were getting for free previously. |
I tried to restart a rebuild of master and now it is failing too, previously it wasn't. Shall I try to add |
I guess it's worth a try. Please take a look at the failure on Brendan's dsterf PR in lapack and see if that failure is the same - I restarted one to see the log (travis doesn't like this machine for unknowable reasons) and it passed, but the rest failed. |
That failure is also from the linker but the reason is different, many errors about undefined references to LAPACKE functions. |
And it doesn't fail for me here either. I'll try replicating on my workstation tomorrow. It's running archaic ubuntu too, so I might be able to repeat there.
|
Adding |
LGTM Presumably you will rebase this onto the new master with -lm? |
The build passes, no rebase is necessary. Merging. |
No description provided.