This repository has been archived by the owner on Dec 9, 2018. It is now read-only.
Clean up comments for blas32/64 routines #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func Axpy(n int, alpha float64, x, y Vector) { | ||
| blas64.Daxpy(n, alpha, x.Data, x.Inc, y.Data, y.Inc) | ||
| } | ||
|
|
||
| // Rotg computes the plane rotation |
There was a problem hiding this comment.
Why the removal of r, c and s? (also below).
There was a problem hiding this comment.
I'm with Dan, adding the definition of z is nice, but shouldn't come with the removal of the others.
There was a problem hiding this comment.
From my point of view the description of r, c and s was redundant because they are already fully described by the matrix/vector relation and the fact that the matrix is a rotation.
vladimir-ch
force-pushed
the
blas-doc-lint
branch
2 times, most recently
from
4b0cc2f
to
0329a8d
Compare
|
PTAL |
|
LGTM |
vladimir-ch
force-pushed
the
blas-doc-lint
branch
from
0329a8d
to
651edf2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.