mat: export Dense.SolveTwoChol

mat/cholesky.go

@@ -182,10 +182,9 @@ func (c *Cholesky) Solve(m *Dense, b Matrix) error {
 	return nil
 }
 
-// TODO(kortschak): Export this as SolveTwoChol.
-// solveTwoChol finds the matrix m that solves A * m = B where A and B are represented
+// SolveTwoChol finds the matrix m that solves A * m = B where A and B are represented
 // by their Cholesky decompositions a and b, placing the result in the receiver.
-func (m *Dense) solveTwoChol(a, b *Cholesky) error {
+func (m *Dense) SolveTwoChol(a, b *Cholesky) error {
 	if !a.valid() || !b.valid() {
 		panic(badCholesky)
 	}

mat/cholesky_test.go

@@ -162,7 +162,7 @@ func TestSolveTwoChol(t *testing.T) {
 		}
 
 		var x Dense
-		x.solveTwoChol(&chola, &cholb)
+		x.SolveTwoChol(&chola, &cholb)
 
 		var ans Dense
 		ans.Mul(test.a, &x)

mat/hogsvd.go

@@ -80,13 +80,13 @@ func (gsvd *HOGSVD) Factorize(m ...Matrix) (ok bool) {
 	defer putWorkspace(sij)
 	for i, ai := range a {
 		for _, aj := range a[i+1:] {
-			gsvd.err = sij.solveTwoChol(&ai, &aj)
+			gsvd.err = sij.SolveTwoChol(&ai, &aj)
 			if gsvd.err != nil {
 				return false
 			}
 			s.Add(s, sij)
 
-			gsvd.err = sij.solveTwoChol(&aj, &ai)
+			gsvd.err = sij.SolveTwoChol(&aj, &ai)
 			if gsvd.err != nil {
 				return false
 			}