travis: replace golangci.com service with travis-local golangci-lint #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortschak
force-pushed
the
travis/range-exp
branch
from
b601784
to
495d95a
Compare
kortschak
force-pushed
the
travis/range-exp
branch
from
d4df5a8
to
3dd2626
Compare
|
ping
|
sbinet
approved these changes
Mar 30, 2020
|
Agreed. I use a source-based install locally. With modules, hopefully they will come around at some point. I've filed golangci/golangci-lint#1006. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look.
The golangci.com linting service is going away next month, so this replaces that with work done on travis. It is a little harsher since it will actually fail a build that fails a lint check, but we can adjust that if needed, and lint checks can be tuned or turned off with
//nolintdirectives.Currently linting cannot be done on arm64, so asm lint won't be checked on that arch for now.