Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph/path: fix YenKShortestPaths #1701

Merged
merged 1 commit into from Aug 27, 2021
Merged

graph/path: fix YenKShortestPaths #1701

merged 1 commit into from Aug 27, 2021

Conversation

kortschak
Copy link
Member

@kortschak kortschak commented Jul 28, 2021

Please take a look.

Fixes #1700.

/cc @liucan002

The corresponding graph rendered is this.

yenk

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021

Codecov Report

Merging #1701 (750ad13) into master (054da3c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1701   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files         510      510           
  Lines       60132    60132           
=======================================
+ Hits        44056    44058    +2     
+ Misses      13584    13583    -1     
+ Partials     2492     2491    -1     
Impacted Files Coverage Δ
graph/path/yen_ksp.go 90.47% <ø> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054da3c...750ad13. Read the comment docs.

@kortschak kortschak added this to the v0.10 milestone Aug 12, 2021
Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wikipedia link indeed reads for i from 0 to size(A[k − 1]) − 2 (and not for i from 0 to size(A[k − 1]) − 1) :)

@kortschak kortschak merged commit 8d530b6 into master Aug 27, 2021
@kortschak kortschak deleted the path/fixyenk branch August 27, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YenKShortestPaths Calculated path error
3 participants