Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph/iterator: allocate reflect map iterator inline #1960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kortschak
Copy link
Member

goos: linux
goarch: amd64
pkg: gonum.org/v1/gonum/graph/traverse
cpu: Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
                                    │  old.bench  │             new.bench              │
                                    │   sec/op    │   sec/op     vs base               │
WalkAllBreadthFirstGnp_10_tenth-8     3.797µ ± 2%   3.609µ ± 3%  -4.95% (p=0.002 n=10)
WalkAllBreadthFirstGnp_100_tenth-8    149.9µ ± 2%   147.8µ ± 3%       ~ (p=0.579 n=10)
WalkAllBreadthFirstGnp_1000_tenth-8   13.12m ± 4%   12.75m ± 2%  -2.76% (p=0.019 n=10)
WalkAllBreadthFirstGnp_10_half-8      8.758µ ± 2%   8.530µ ± 1%  -2.61% (p=0.000 n=10)
WalkAllBreadthFirstGnp_100_half-8     624.3µ ± 2%   618.2µ ± 2%       ~ (p=0.143 n=10)
WalkAllBreadthFirstGnp_1000_half-8    60.83m ± 3%   58.88m ± 6%       ~ (p=0.052 n=10)
WalkAllDepthFirstGnp_10_tenth-8       3.763µ ± 2%   3.568µ ± 2%  -5.18% (p=0.002 n=10)
WalkAllDepthFirstGnp_100_tenth-8      150.5µ ± 3%   145.0µ ± 1%  -3.66% (p=0.000 n=10)
WalkAllDepthFirstGnp_1000_tenth-8     12.79m ± 2%   12.70m ± 6%       ~ (p=0.579 n=10)
WalkAllDepthFirstGnp_10_half-8        8.662µ ± 2%   8.333µ ± 4%  -3.79% (p=0.015 n=10)
WalkAllDepthFirstGnp_100_half-8       637.1µ ± 1%   629.2µ ± 4%       ~ (p=0.739 n=10)
WalkAllDepthFirstGnp_1000_half-8      59.31m ± 5%   57.91m ± 1%  -2.36% (p=0.001 n=10)
geomean                               366.6µ        356.5µ       -2.75%

                                    │   old.bench   │              new.bench               │
                                    │     B/op      │     B/op       vs base               │
WalkAllBreadthFirstGnp_10_tenth-8      1.627Ki ± 0%    1.533Ki ± 0%  -5.76% (p=0.000 n=10)
WalkAllBreadthFirstGnp_100_tenth-8     31.16Ki ± 0%    29.58Ki ± 0%  -5.07% (p=0.000 n=10)
WalkAllBreadthFirstGnp_1000_tenth-8   1032.0Ki ± 0%   1016.4Ki ± 0%  -1.52% (p=0.000 n=10)
WalkAllBreadthFirstGnp_10_half-8       2.861Ki ± 0%    2.689Ki ± 0%  -6.01% (p=0.000 n=10)
WalkAllBreadthFirstGnp_100_half-8      63.02Ki ± 0%    61.44Ki ± 0%  -2.50% (p=0.000 n=10)
WalkAllBreadthFirstGnp_1000_half-8     4.052Mi ± 0%    4.036Mi ± 0%  -0.38% (p=0.000 n=10)
WalkAllDepthFirstGnp_10_tenth-8        1.627Ki ± 0%    1.533Ki ± 0%  -5.76% (p=0.000 n=10)
WalkAllDepthFirstGnp_100_tenth-8       31.16Ki ± 0%    29.58Ki ± 0%  -5.07% (p=0.000 n=10)
WalkAllDepthFirstGnp_1000_tenth-8      1.108Mi ± 1%    1.092Mi ± 1%  -1.43% (p=0.000 n=10)
WalkAllDepthFirstGnp_10_half-8         2.861Ki ± 0%    2.689Ki ± 0%  -6.01% (p=0.000 n=10)
WalkAllDepthFirstGnp_100_half-8        63.14Ki ± 0%    61.56Ki ± 0%  -2.51% (p=0.000 n=10)
WalkAllDepthFirstGnp_1000_half-8       6.294Mi ± 2%    6.279Mi ± 0%  -0.24% (p=0.000 n=10)
geomean                                60.94Ki         58.78Ki       -3.55%

                                    │  old.bench  │              new.bench              │
                                    │  allocs/op  │  allocs/op   vs base                │
WalkAllBreadthFirstGnp_10_tenth-8      33.00 ± 0%    27.00 ± 0%  -18.18% (p=0.000 n=10)
WalkAllBreadthFirstGnp_100_tenth-8    1.289k ± 0%   1.188k ± 0%   -7.84% (p=0.000 n=10)
WalkAllBreadthFirstGnp_1000_tenth-8   103.1k ± 0%   102.1k ± 0%   -0.97% (p=0.000 n=10)
WalkAllBreadthFirstGnp_10_half-8       81.00 ± 0%    70.00 ± 0%  -13.58% (p=0.000 n=10)
WalkAllBreadthFirstGnp_100_half-8     5.367k ± 0%   5.266k ± 0%   -1.88% (p=0.000 n=10)
WalkAllBreadthFirstGnp_1000_half-8    501.9k ± 0%   500.9k ± 0%   -0.20% (p=0.000 n=10)
WalkAllDepthFirstGnp_10_tenth-8        33.00 ± 0%    27.00 ± 0%  -18.18% (p=0.000 n=10)
WalkAllDepthFirstGnp_100_tenth-8      1.289k ± 0%   1.188k ± 0%   -7.84% (p=0.000 n=10)
WalkAllDepthFirstGnp_1000_tenth-8     103.1k ± 0%   102.1k ± 0%   -0.97% (p=0.000 n=10)
WalkAllDepthFirstGnp_10_half-8         81.00 ± 0%    70.00 ± 0%  -13.58% (p=0.000 n=10)
WalkAllDepthFirstGnp_100_half-8       5.367k ± 0%   5.266k ± 0%   -1.88% (p=0.000 n=10)
WalkAllDepthFirstGnp_1000_half-8      501.9k ± 0%   500.9k ± 0%   -0.20% (p=0.000 n=10)
geomean                               3.139k        2.908k        -7.36%

Please take a look.

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.39%. Comparing base (8a2036b) to head (38e7d61).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1960   +/-   ##
=======================================
  Coverage   72.38%   72.39%           
=======================================
  Files         556      556           
  Lines       65134    65148   +14     
=======================================
+ Hits        47147    47161   +14     
  Misses      15385    15385           
  Partials     2602     2602           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kortschak
Copy link
Member Author

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants